Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style #726

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Code style #726

merged 4 commits into from
Jul 14, 2024

Conversation

lav45
Copy link
Contributor

@lav45 lav45 commented Jul 13, 2024

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@codecov Codecov
Copy link

codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (fe63447) to head (96a3d37).
Report is 37 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #726      +/-   ##
============================================
- Coverage     94.40%   94.28%   -0.12%     
- Complexity      953     1009      +56     
============================================
  Files           108      118      +10     
  Lines          3018     3149     +131     
============================================
+ Hits           2849     2969     +120     
- Misses          169      180      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vjik
vjik requested changes Jul 14, 2024
View reviewed changes
src/Result.php Show resolved Hide resolved
vjik
vjik approved these changes Jul 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik requested a review from a team July 14, 2024 17:38
@vjik vjik added the status:code review The pull request needs review. label Jul 14, 2024
@samdark @vjik
Update CHANGELOG.md
5c474ba 
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
@samdark samdark merged commit 02ad73d into yiisoft:master Jul 14, 2024
23 of 24 checks passed
@samdark
Copy link
Member

samdark commented Jul 14, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lav45 @samdark @vjik